Fix RedisUtils.isUnlinkAvailable() for NPE
#2870
Conversation
Fixes spring-projects#2868 * Check if `redis_version` property is returned from the `info` before parsing **Cherry-pick to 5.1.x**
| return majorVersion >= 4; | ||
| } | ||
| else { | ||
| return false; |
There was a problem hiding this comment.
I wonder if we should fall back to a spring.integration.properties?
Clearly, their version supports the operation.
There was a problem hiding this comment.
Huh? What is the difference between spring.integration.properties or redis_version property?
Technically they are the same, only the problem that you abusing a system renaming such an important property.
I mean the same way you definitely can change the property in the spring.integration.properties file and also may break the system
Our goal here is to use faster delete on Redis, if it is not available by some reason we fall back to the regular blocking delete.
So, if you rename redis_version, you just make your own life harder 😄
That's why I'd stay with the false as a fallback.
There was a problem hiding this comment.
OK; makes sense; thanks.
|
Cherry-picked to 5.1.x as 659613c |
2 participants
Fixes #2868
redis_versionproperty is returned from theinfobefore parsing
Cherry-pick to 5.1.x